Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: calling prebuild only if deps are installed #3217

Merged
merged 12 commits into from
Sep 26, 2024
Merged

fix: calling prebuild only if deps are installed #3217

merged 12 commits into from
Sep 26, 2024

Conversation

Torres-ssf
Copy link
Contributor

@Torres-ssf Torres-ssf commented Sep 26, 2024 •
edited
Loading

Summary

This PR fixes an issue related to calling the prebuild command in a newly bootstrapped create-fuels project. The prebuild command is intended to generate Typegen files, but it was also executed when dependencies were not installed due to the --no-install flag.

Checklist

  • All changes are covered by tests (or not applicable)
  • All changes are documented (or not applicable)
  • I reviewed the entire PR myself (preferably, on GH UI)
  • I described all Breaking Changes (or there's none)

@Torres-ssf Torres-ssf self-assigned this Sep 26, 2024
@vercel Vercel
Copy link

vercel bot commented Sep 26, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
create-fuels-template ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 26, 2024 8:13pm
ts-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 26, 2024 8:13pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
create-fuels-counter-example ⬜️ Ignored (Inspect) Sep 26, 2024 8:13pm

@github-actions github-actions bot added the bug Issue is a bug label Sep 26, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 26, 2024 •
edited
Loading

This PR is published in NPM with version 0.0.0-pr-3217-20240926163336

@Torres-ssf Torres-ssf changed the title fix: create-fuels fix: prevent create-fiels running prebuild when deps are not installed Sep 26, 2024
@Torres-ssf Torres-ssf changed the title fix: prevent create-fiels running prebuild when deps are not installed fix: prevent create-fuels running prebuild when deps were not installed Sep 26, 2024
@Torres-ssf Torres-ssf marked this pull request as ready for review September 26, 2024 17:23
@Torres-ssf Torres-ssf changed the title fix: prevent create-fuels running prebuild when deps were not installed fix: prevent create-fuels running prebuild when deps were not installed Sep 26, 2024
@Torres-ssf Torres-ssf changed the title fix: prevent create-fuels running prebuild when deps were not installed fix: prevent create-fuels running prebuild when deps were not installed Sep 26, 2024
@arboleya arboleya changed the title fix: prevent create-fuels running prebuild when deps were not installed fix: calling prebuild only if deps are installed Sep 26, 2024
@arboleya arboleya enabled auto-merge (squash) September 26, 2024 18:06
@github-actions GitHub Actions
Copy link
Contributor

Coverage Report:

Lines Branches Functions Statements
76.38%(-0.79%) 71.58%(-0.23%) 75.49%(-0.28%) 76.54%(-0.74%)
Changed Files:
Ok File (✨=New File) Lines Branches Functions Statements
🔴 ✨ apps/docs-snippets2/scripts/launcher-snippet.ts 0%
(+0%)		 100%
(+100%)		 0%
(+0%)		 0%
(+0%)
🔴 ✨ apps/docs-snippets2/scripts/test-template.ts 0%
(+0%)		 0%
(+0%)		 0%
(+0%)		 0%
(+0%)
🔴 ✨ apps/docs-snippets2/scripts/wrap-snippets.ts 0%
(+0%)		 0%
(+0%)		 0%
(+0%)		 0%
(+0%)
🔴 ✨ apps/docs-snippets2/src/env.ts 0%
(+0%)		 100%
(+100%)		 100%
(+100%)		 0%
(+0%)
🔴 ✨ apps/docs-snippets2/src/introduction/connecting-to-localnode.ts 0%
(+0%)		 100%
(+100%)		 100%
(+100%)		 0%
(+0%)
🔴 ✨ apps/docs-snippets2/src/introduction/connecting-to-testnet.ts 0%
(+0%)		 100%
(+100%)		 100%
(+100%)		 0%
(+0%)
🔴 ✨ apps/docs-snippets2/src/transactions/transaction-parameters.ts 0%
(+0%)		 100%
(+100%)		 100%
(+100%)		 0%
(+0%)
🔴 ✨ apps/docs-snippets2/src/typegend/contracts/Counter.ts 66.66%
(+66.66%)		 100%
(+100%)		 0%
(+0%)		 66.66%
(+66.66%)
✅ ✨ apps/docs-snippets2/src/typegend/contracts/CounterFactory.ts 100%
(+100%)		 100%
(+100%)		 100%
(+100%)		 100%
(+100%)
🔴 ✨ apps/docs-snippets2/src/typegend/scripts/ScriptSum.ts 80%
(+80%)		 100%
(+100%)		 0%
(+0%)		 80%
(+80%)
🔴 packages/account/src/providers/transaction-request/transaction-request.ts 88.57%
(+0%)		 76.71%
(-1.37%)		 84%
(+0%)		 88.81%
(+0%)
🔴 packages/create-fuels/src/cli.ts 86.74%
(-0.43%)		 42.85%
(-4.51%)		 100%
(+0%)		 86.74%
(-0.43%)
🔴 ✨ packages/fuels/scripts/build-proxy-contract.ts 0%
(+0%)		 100%
(+100%)		 100%
(+100%)		 0%
(+0%)
🔴 packages/fuels/src/cli/commands/deploy/deployContract.ts 100%
(+0%)		 83.33%
(+33.33%)		 100%
(+0%)		 100%
(+0%)
🔴 ✨ packages/fuels/src/cli/commands/deploy/proxy/types/Src14OwnedProxy.ts 83.33%
(+83.33%)		 100%
(+100%)		 75%
(+75%)		 91.66%
(+91.66%)
🔴 ✨ packages/fuels/src/cli/commands/deploy/proxy/types/Src14OwnedProxyFactory.ts 66.66%
(+66.66%)		 0%
(+0%)		 66.66%
(+66.66%)		 66.66%
(+66.66%)
🔴 packages/fuels/src/cli/config/forcUtils.ts 92.98%
(-7.02%)		 80%
(-20%)		 100%
(+0%)		 93.44%
(-6.56%)

@arboleya arboleya merged commit 327b309 into master Sep 26, 2024
24 checks passed
@arboleya arboleya deleted the st/fix/create-fuels branch September 26, 2024 20:25
@fuel-service-user fuel-service-user mentioned this pull request Sep 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arboleya arboleya arboleya approved these changes

@danielbate danielbate danielbate approved these changes

@maschad maschad maschad approved these changes

@digorithm digorithm Awaiting requested review from digorithm digorithm is a code owner

@Dhaiwat10 Dhaiwat10 Awaiting requested review from Dhaiwat10 Dhaiwat10 is a code owner

@nedsalk nedsalk Awaiting requested review from nedsalk nedsalk is a code owner

@petertonysmith94 petertonysmith94 Awaiting requested review from petertonysmith94 petertonysmith94 is a code owner

Assignees

@Torres-ssf Torres-ssf

Labels
bug Issue is a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Torres-ssf @arboleya @danielbate @maschad